FIO-9360: validate current page only on wizard change #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
- this.validate() is only called in onChange() if the form previously failed to submit. Because of this, the form will already be dirty, so it makes sense to reiterate this by passing dirty: true instead of false.
7 tasks
lane-formio
pushed a commit
that referenced
this pull request
Nov 26, 2024
* validate current page on wizard change * add tests * fix tests * Specify correct flag for form validation after failed wizard submission - this.validate() is only called in onChange() if the form previously failed to submit. Because of this, the form will already be dirty, so it makes sense to reiterate this by passing dirty: true instead of false. --------- Co-authored-by: Blake Krammes <49688912+blakekrammes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9360
Description
This PR reverts:
to consolidate validation of Wizard components into one simple rule: on change, only validate and show the current page's validation errors unless you've already attempted to submit the form.
Breaking Changes / Backwards Compatibility
Technically this is a breaking change - previously, the renderer would validate all components (much like it does with forms) and selectively display them based on the UI's context. However, this proves to be tricky with nested forms, and it's easiest to just only validate the currently displayed components when it comes to wizards.
Dependencies
n/a
How has this PR been tested?
All tests pass. Added a few automated tests to ensure that Wizards will only validate currently displayed components.
Checklist: